VietNam Mobile new NDC code

floere / phony

E164 international phone number normalizing, splitting, formatting.

http://florianhanke.com/phony/

MIT License

1.01k stars 226 forks source link

VietNam Mobile new NDC code #421

Closed narutoo9x closed 5 years ago

narutoo9x commented 5 years ago

related #417

You can check new vietnam NDC code here

coveralls commented 5 years ago

Coverage increased (+0.0002%) to 99.406% when pulling 2c32cd9a20dd414400756f82652951053c547f0b on narutoo9x:master into 392d205f0bdbbf86f195339033dbfc7dbd981d79 on floere:master.

floere commented 5 years ago

Hi @narutoo9x – thanks for the PR! 👍 Unfortunately I am getting a failing assertion here:

***** FAIL *****
(assertion) Phony plausible? "+84 4 3926 1720"
/Users/admin/temp/phony/qed/plausibility.md:879
    877
    878     Phony.assert.plausible?('+84 8 3827 9666')
 => 879     Phony.assert.plausible?('+84 4 3926 1720')
    880     Phony.assert.plausible?('+84 091 123-4567')
    881     Phony.assert.plausible?('+84 034 123456')

Can you help me with this one? (You can run the specs with bundle exec rake)

floere commented 5 years ago

From your changes I am assuming it should be 24 instead of 4. Am I correct?

narutoo9x commented 5 years ago

I ran the test in the local, and nothing was wrong, it weird. Btw you are correct