Updating Austrian number requirements

floere / phony

E164 international phone number normalizing, splitting, formatting.

http://florianhanke.com/phony/

MIT License

1.01k stars 226 forks source link

Updating Austrian number requirements #448

Closed scott2211 closed 5 years ago

scott2211 commented 5 years ago

Updated the link to the Austrian numbering plan (nothing changed, just the URL)
Updated the length requirements for ndcs numbers from 6 to 5

I have an example of a valid number for the Klagenfurt region that has 5 digits after the ndc code. I'm not sure if the change included here is good or should I split 463 into it's own case?

coveralls commented 5 years ago

Coverage remained the same at 98.445% when pulling b372fd57a42a2f03d871a638aa840cb81b9047c0 on scott2211:scott2211/update-austrian-number-length into 798ddb1da2aad54a44a6a588f545a659bb31db41 on floere:master.

floere commented 5 years ago

@scott2211 Thanks for the useful PR, Scott! 😊 I'm unsure about splitting it into its own case since the numbering plan mentions 6 as the minimum length – what is the number?

scott2211 commented 5 years ago

Hey, the number is +4346349133. Example company listing here: https://finde-offen.at/klagenfurt-am-worthersee/georg-huainig-kfz-reparatur-und-handels-gesellschaft-mbh-43960

floere commented 5 years ago

@scott2211 Thanks again! 🎉 Released in 2.18.8 😊🚀

scott2211 commented 5 years ago

Amazing, thank you!