search

floere / phony

E164 international phone number normalizing, splitting, formatting.
http://florianhanke.com/phony/
MIT License
1.01k stars 226 forks source link

Add new Gabonese Republic phone number format #470

Closed Startouf closed 4 years ago

Startouf commented 4 years ago

resolves https://github.com/floere/phony/issues/461

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.2%) to 98.416% when pulling 6755d4d26dd9b9971de724c33398ca7b1b6b7075 on Startouf:patch-1 into e8f6924c9be6d3e5904b927f9900048c9a9e3ed0 on floere:master.

Startouf commented 4 years ago

@floere coverage seems to have decreased, but this does not seem to be linked to my PR does it ?

floere commented 4 years ago

Hi @Startouf! Thanks very much for this PR! 🎉 Unfortunately, and this is my bad, the process did not catch two errors, which you can see here: https://travis-ci.org/github/floere/phony/jobs/713237721 That is now fixed locally. I then tried to fix the specs – but the issue is that with the definitions fixed(1) … and fixed(2) … the first will always match. Looking at https://en.wikipedia.org/wiki/Telephone_numbers_in_Gabon, I am unsure what the rules should be – can you point me in the right direction? 😊 Thanks!