search

flofreud / posh-gvm

GVM for Powershell
Apache License 2.0
210 stars 60 forks source link

Problems when attempting to use a Proxy #8

Open santidhammo opened 8 years ago

santidhammo commented 8 years ago

I have found that the current implementation does not support proxies, therefore, I adapted the Utils.ps1 file to support a reasonable amount of pre-configured proxies. Also, I found an issue when using Powershell ISE, which I have circumvented, but needs attention.

User.ps1.txt

flofreud commented 8 years ago

First of all: thank you for the contribution. Could you please provide your changes as a Github Pull-Request? The changes would be easier to track and it would also be easier to integrate. Currently my time to invest into posh-gvm is greatly limited.

santidhammo commented 8 years ago

I can surely do that. Op 15 nov. 2015 16:25 schreef "Florian Freudenberg" < notifications@github.com>:

First of all: thank you for the contribution. Could you please provide your changes as a Github Pull-Request? The changes would be easier to track and it would also be easier to integrate. Currently my time to invest into posh-gvm is greatly limited.

— Reply to this email directly or view it on GitHub https://github.com/flofreud/posh-gvm/issues/8#issuecomment-156817898.

flofreud commented 8 years ago

Great! :)

Sjoerd van Leent notifications@github.com schrieb am Sa., 21. Nov. 2015, 14:54:

I can surely do that. Op 15 nov. 2015 16:25 schreef "Florian Freudenberg" < notifications@github.com>:

First of all: thank you for the contribution. Could you please provide your changes as a Github Pull-Request? The changes would be easier to track and it would also be easier to integrate. Currently my time to invest into posh-gvm is greatly limited.

— Reply to this email directly or view it on GitHub https://github.com/flofreud/posh-gvm/issues/8#issuecomment-156817898.

— Reply to this email directly or view it on GitHub https://github.com/flofreud/posh-gvm/issues/8#issuecomment-158642838.

nmaynes commented 8 years ago

Did this request ever get merged?

flofreud commented 8 years ago

The pull-request #9 is still open due to the open points discussed there. I hadn't the time to make the necessary changes myself.

Furthermore I still have to do #7 and have to see if I implement the proxy support in this old gvm version or in the new SDKMAN version.

Is this a blocker for you? I could try to find some time this evening and merge it if I'm sure not to break more than this solve ;)

nmaynes commented 8 years ago

This is not a show stopper for me. Focusing on the SDKMAN version is probably wisest. If you need help with particular issues I am happy to offer assistance.

On Fri, Jan 29, 2016, 7:04 AM Florian Freudenberg notifications@github.com wrote:

The pull-request #9 https://github.com/flofreud/posh-gvm/pull/9 is still open due to the open points discussed there. I hadn't the time to make the necessary changes myself.

Furthermore I still have to do #7 https://github.com/flofreud/posh-gvm/issues/7 and have to see if I implement the proxy support in this old gvm version or in the new SDKMAN version.

Is this a blocker for you? I could try to find some time this evening and merge it if I'm sure not to break more than this solve ;)

— Reply to this email directly or view it on GitHub https://github.com/flofreud/posh-gvm/issues/8#issuecomment-176722658.

santidhammo commented 8 years ago

It is still a show-stopper at my location. Though if there would be an option to tell the downloader to use a different github source, it would also remediate the problem for now.

Met vriendelijke groet, Sjoerd

2016-01-29 17:56 GMT+01:00 Nathan M notifications@github.com:

This is not a show stopper for me. Focusing on the SDKMAN version is probably wisest. If you need help with particular issues I am happy to offer assistance.

On Fri, Jan 29, 2016, 7:04 AM Florian Freudenberg < notifications@github.com> wrote:

The pull-request #9 https://github.com/flofreud/posh-gvm/pull/9 is still open due to the open points discussed there. I hadn't the time to make the necessary changes myself.

Furthermore I still have to do #7 https://github.com/flofreud/posh-gvm/issues/7 and have to see if I implement the proxy support in this old gvm version or in the new SDKMAN version.

Is this a blocker for you? I could try to find some time this evening and merge it if I'm sure not to break more than this solve ;)

— Reply to this email directly or view it on GitHub https://github.com/flofreud/posh-gvm/issues/8#issuecomment-176722658.

— Reply to this email directly or view it on GitHub https://github.com/flofreud/posh-gvm/issues/8#issuecomment-176859516.