search

floh22 / LeagueBroadcast

League of Legends Spectate Overlay Tools
MIT License
218 stars 46 forks source link

Update Farsight for 64bit League #249

Closed FFFFFFFXXXXXXX closed 1 year ago

FFFFFFFXXXXXXX commented 1 year ago

I updated the Farsight module to work with the new 64bit game client and added offsets for 13.7.1.

floh22 commented 1 year ago

Looks good. One question, what is the rationale for introducing the level offset when level can be directly calculated from EXP? Seems like more maintanence work to me

FFFFFFFXXXXXXX commented 1 year ago

I assumed the level-from-exp calculation was because there was no offset for the level before the 64bit version (or i atleast didnt see one before). If you prefer calculating it instead of getting it from the offset I can remove it?

floh22 commented 1 year ago

It's fine, though as far as I can tell update code is missing to manage the file version change, which might break the program for those updating versions and would force a manual deletion of the config file. Have you tested this and it works anyway? I am currently not able to access an environment where I can test this myself.

It would be great if you could add the migration code or revert back to not using the offset, either works fine

FFFFFFFXXXXXXX commented 1 year ago

Im currently looking into migration code, since we atleast need the new NameLength offset (GameObject.Name is now a packed string).

FFFFFFFXXXXXXX commented 1 year ago

Alright, I think I got it. I incremented the FarsightConfig version to 3, which forces an update of the offsets. It tested it on my local version. Does this work for all cases or did I miss something?

floh22 commented 1 year ago

Looks good I think

floh22 commented 1 year ago

I'll build and deploy tomorrow evening once I get access to my PC