floh22 / LeagueBroadcast

League of Legends Spectate Overlay Tools
MIT License
218 stars 46 forks source link

Quick Fix #301 / Improve OnDamageGiven handling #306

Closed sdomi4 closed 9 months ago

sdomi4 commented 10 months ago

This should be the easiest/least painful temporary fix for the crashes related to turret damage seen in #301. Removing the handling of OnDamageGiven events for now shouldn't be a big deal as this part of the code is still WIP as far as I can tell.

@floh22 Needs your review/approval, I will leave merging/releasing a new version to you since I have no idea about the build setup.

sdomi4 commented 10 months ago

Updated PR to not just straight up ignore OnDamageGiven events since it's actually used for turret plates.