floh22 / LeagueBroadcast

League of Legends Spectate Overlay Tools
MIT License
218 stars 46 forks source link

[BUG] No ScoreBoardPopUps for the new Hextech/Chemtech dragons #89

Closed FireFoXz09 closed 1 year ago

FireFoXz09 commented 2 years ago

Missing folders for the scoreboardPopUps when the new dragon type spawns or gets killed. I dunno if it is created or programmed in the code yet (I haven't seen it in the config/Ingame.json). It did nothing on my side when i tested it a few minutes ago.

Folder : LeagueBroadcast-1.4.106\Frontend\ingame\images\scoreboardPopUps

Missing the Hextech type and the Chemtech type.

floh22 commented 2 years ago

Until I have time to fix it, add the corresponding folders and files to the overlay files. This means you have to add the folders Hextech and Chemtech to Frontend/ingame/images/scoreboardPopUps/Dragon and then add the corresponding files as well.

Edit: Fixed folder location

FireFoXz09 commented 2 years ago

If I just need to add the folders and pictures/video like for the same dragons, I can do that ;) I'll try it and let you know if this works!

shinilee commented 2 years ago

I just did but it only work for kill spwan doesn't work for me for the new dragons old dragon still popup for spawn but new dragon doesn't work but it work for kill popup for the new dragon

for popup I use video for kill I use image

FireFoXz09 let me know if your test

FireFoXz09 commented 2 years ago

The popups works for the kills of the new dragons (I dunno for the spawn since I never use them, I'll try later this week), but the icon in the scoreboard the the chemtech or hextech dragons won't load. (it puts the blacksquare with a green bar like if they can't find the picture)

Screenshot 2021-11-22 18-32-29

shinilee commented 2 years ago

mine working fine for score display dragon it just spwan not working for me

floh22 commented 2 years ago

Try deleting the Frontend folder and then replacing it again, it might be possible that the update failed to overwrite the old files it needed to. Make sure Frontend/ingame/images/dragons contains both chemtechLarge.png and hextechLarge.png

As for the popups, the folder location i wrote was missing the last component, make sure to add the new folders inside the Dragon folder

shinilee commented 2 years ago

Try deleting the Frontend folder and then replacing it again, it might be possible that the update failed to overwrite the old files it needed to. Make sure Frontend/ingame/images/dragons contains both chemtechLarge.png and hextechLarge.png

As for the popups, the folder location i wrote was missing the last component, make sure to add the new folders inside the Dragon folder

image

this is my setup but you saying I have make another dragon fonder and put Chemtech, Hextech in to that folder?

overkido commented 2 years ago

How do you add an image to the background of the inhibitors, in my one, it bugs and the image does not appear in the background?

image

How do I put the drag folders and images when it is killed?

image

shinilee commented 2 years ago

I just tried to add another dragon folder in the dragon folder and it didn't work and now kill popup doesn't even working

image

overkido commented 2 years ago

taking advantage, would it be possible to remove the client's timer to add to the program's hub?, like in the world and msi, that the herald drags and fine baron timers in the program's hub?

image

overkido commented 2 years ago

even to be able to customize it would be better for the people who make the championships.

the showlogo of drags and baron doesn't work either, i've activated it, but when drag or baron kills it doesn't show the logo of the team that made it.

imagem

overkido commented 2 years ago

does anyone know where i change the video file format from mp4 to mov? I've looked for it, I haven't found it.

shinilee commented 2 years ago

image

the new dragon popup working after 2nd one 1st dragon doesn't popup for the newdragon

  1. Firedragon popup work
  2. Mountain dragon popup work
  3. chemtech dragon popup not work
  4. chemtech dragon popup work
  5. chemtech dragon popup work

I think it's bug

floh22 commented 2 years ago

Try deleting the Frontend folder and then replacing it again, it might be possible that the update failed to overwrite the old files it needed to. Make sure Frontend/ingame/images/dragons contains both chemtechLarge.png and hextechLarge.png As for the popups, the folder location i wrote was missing the last component, make sure to add the new folders inside the Dragon folder

image

this is my setup but you saying I have make another dragon fonder and put Chemtech, Hextech in to that folder?

This is correct. I will add missing files at some point in the future when I have access to my workstation again.

floh22 commented 2 years ago

As for the rest of this issue, this is not a support thread. If you have an issue, please open a separate issue for the topic and make sure your issue is not a duplicate of an existing one.

Custom timers are not supported as of this moment and only .mp4 files are supported. If you have .movs, convert them.

shinilee commented 2 years ago

image

the new dragon popup working after 2nd one 1st dragon doesn't popup for the newdragon

  1. Firedragon popup work
  2. Mountain dragon popup work
  3. chemtech dragon popup not work
  4. chemtech dragon popup work
  5. chemtech dragon popup work

I think it's bug

I just test run again and it's working now the new dragon popup working without any problem I think it's just glitch

https://youtu.be/1B8o-DXFJsU

FireFoXz09 commented 2 years ago

How do you add an image to the background of the inhibitors, in my one, it bugs and the image does not appear in the background?

image

How do I put the drag folders and images when it is killed?

image

The inhibitor countdown don't have a background image cause I had the same issue, it bugged. I just made this in my in-game overlay and put the inhibitor timer above it.

overkido commented 2 years ago

no caso vc fez uma arte base e jogo o link por cima sem o alfa do inibidor e sem imagem ?

overkido commented 2 years ago

Eu tentei colocar o redside do outro lado do mapa, encima do mini-mapa mas não consegui, ai deixei assim tbm, queria por redside no outro lado e assim ter mais espaço pra personalizar mas não funcionou.

FireFoXz09 commented 2 years ago

I solved the problem for the dragon icon in the score on the top of the overlay. I did a bad copy-paste of the CONFIF files from my old setup to the new version. Everything works as planned! :)