Bugfix/handle hidapi exceptions in sendReport

flok / pydualsense

control your dualsense controller with python

MIT License

112 stars 33 forks source link

Bugfix/handle hidapi exceptions in sendReport #55

Open dalethomas81 opened 4 months ago

dalethomas81 commented 4 months ago

Handle an exception generated by hidapi in the sendReport thread. This exception is thrown when no controller is connected. Since the exception is not handled, the thread ends, and the service needs to be restarted to recover. By handling these exceptions, the service becomes fault tolerant and is able to recover automatically.

Added a Try/Exception to handle an IOError and an AttributeError.
Added a Connected property to indicate when the device is not connected.

flok commented 4 months ago

Thanks for the pull request, i added some remarks :)

dalethomas81 commented 4 months ago

Hey @flok - sorry, I am not seeing the remarks. Where can I find them?

dalethomas81 commented 4 months ago

Btw, this fixes #48.

flok commented 4 months ago

Hey @flok - sorry, I am not seeing the remarks. Where can I find them?

You should see them in this thread at the top as a review from me

dalethomas81 commented 4 months ago

I believe you may not have submitted the review request as there are none. Do you mind trying again or pasting your review here? Thank you for your patience. I am enjoying using this in my project.

flok commented 4 months ago

I believe you may not have submitted the review request as there are none. Do you mind trying again or pasting your review here? Thank you for your patience. I am enjoying using this in my project.

You are right, my bad. Mostly working with gitlab now a days and forgot to press the button. You should be able to see it now

dalethomas81 commented 3 months ago

No worries! I did respond to your review. Can you let me know if that is satisfactory? Thank you.