search

flokli / gerrit-queue

A merge bot for Gerrit
Apache License 2.0
17 stars 2 forks source link

use go:embed instead of statik, require go1.16, remove shell.nix #9

Closed flokli closed 2 years ago

flokli commented 2 years ago 
commit d68e2a4aaeeaf123891ab088d8a494cfe35ffe6a
Author: Florian Klink <flokli@flokli.de>
Date:   Tue Dec 14 17:30:49 2021 +0100

    add github actions

commit ab237bd71bcde3606e93ab18a97995f4645da93b
Author: Florian Klink <flokli@flokli.de>
Date:   Tue Dec 14 17:29:47 2021 +0100

    submitqueue/runner.go: fix format string

commit 8775075577f54eef7749f9a47af7c60c7c33a1c0
Author: Florian Klink <flokli@flokli.de>
Date:   Tue Dec 14 17:23:56 2021 +0100

    use go:embed instead of statik, require go1.16, remove shell.nix

    Previously, gerrit-queue used statik to embed files. Since go1.16, we
    have go:embed, which solves this much nicer, without any requirements to
    have the statik binary around.

    As the only other thing the shell.nix and .envrc plumbing did was bring
    a version of Go in scope, it's dropped now. We assume to have a
    recent-enough go binary around, else go will complain.
flokli commented 2 years ago

cc @tazjin

tazjin commented 2 years ago

LGTM