search

flokol120 / Spigot-Item-Chest-Sorter

A Spigot/Paper minecraft plugin to sort your messy items into separate chests | 💯% written in Kotlin
GNU General Public License v3.0
5 stars 6 forks source link

Shulkerbox into shulkerbox into ... #14

Closed FirstLadyAnna closed 3 years ago

FirstLadyAnna commented 3 years ago

Es ist bei Minecraft nicht umsonst unmöglich, Shulkerkisten in Shulkerkisten zu füllen! Mit ICS geht das aber! Spieler können eine Shulkerkiste als Empfänger einrichten und können die gefüllten Shulkerkisten in den Sender packen. Damit werden die gefüllten Shulkerkisten in eine Shulkerkiste gepackt und diese kann man dann abbauen und theoretisch wieder in eine Senderkiste packen. Irgendwann rechnet sich der Server dann tot. Bitte verhindere, dass man Shulkerkisten als Empfänger definieren kann, sonst ist das Plugin unbrauchbar.

flokol120 commented 3 years ago

@FirstLadyAnna Thanks for your input. This makes total sense. The next time you file an issue on GitHub, make sure to formulate it in english for others to understand. It is really annoying to find something you cannot understand. Short translation: It is possible to define shulker boxes as senders and receivers. Shulker boxes, however are meant to be picked up. This leads to the server looking for a box which could be just gone.

This "issue" however also applies to other containers: If you break a chest within a sender/receiver system the server cannot find it. But I do understand that shulker boxes are meant to be broken. I will add a new param to the config file which controls whether shulker boxes are allowed or not.

This should be an easy fix.

FirstLadyAnna commented 3 years ago

Sorry for my bad english. Iam glad that you will fix it. Server chrashes are not nice

flokol120 commented 3 years ago

@FirstLadyAnna No need to apologize, my english is far from perfect as well. It is already fixed. If you want it to be disabled, you just have to replace the .jar file in your plugins folder with the newest 1.7.1 version.

FirstLadyAnna commented 3 years ago

Many Thanks for quick response and quick fix!!! Its terrific! Unfortunately, the players can still dismantle the already registered receiver box and place a shulker box instead. Since only the location of the box is registered, it is unfortunately still possible to pack Shulker boxes in Shulker boxes. It's a very good plugin, please, can you fix that too?

flokol120 commented 3 years ago

@FirstLadyAnna Oh, Touché. I will try to detect that. But preventing that in the first place would be more tricky. But I will look into that...

flokol120 commented 3 years ago

@FirstLadyAnna If a chest is replaced with a shulker box, the plugin refuses to send items to it. Please report back if it is fixed now.

FirstLadyAnna commented 3 years ago

I'm so happy! Now it's perfect! Nice job, and especially so fast! Thank you very much!

flokol120 commented 3 years ago

@FirstLadyAnna Glad you like it! You were lucky you got me on a free sunday. Usually I am not that fast if I got other work to do :stuck_out_tongue:

FirstLadyAnna commented 3 years ago

All's well that ends well.