search

flokol120 / Spigot-Item-Chest-Sorter

A Spigot/Paper minecraft plugin to sort your messy items into separate chests | 💯% written in Kotlin
GNU General Public License v3.0
5 stars 6 forks source link

Adds ability to use regular expressions in sets #2

Closed corylulu closed 4 years ago

corylulu commented 4 years ago

Only the individual parts of the code have been tested, but I haven't compiled the whole plugin, but pretty sure this should work.

Setting enableSetsRegex to true shouldn't have any adverse effects on existing sets since no characters need escaping so I think everything should work fine.

flokol120 commented 4 years ago

Very cool! Thank you very much! I'll make a little code review and test the feature.

corylulu commented 4 years ago

Awesome, I haven't worked with Kotlin / Gradle before, so I'm still trying to figure out how to compile, but I'm trying as well.

flokol120 commented 4 years ago

Awesome, I haven't worked with Kotlin / Gradle before, so I'm still trying to figure out how to compile, but I'm trying as well.

@corylulu cool! I hope you'll dive deeper into it. Kotlin is just awsome imho! Which IDE are you using? Maybe I can help with your compilation problems.

flokol120 commented 4 years ago

The rest looks solid! But I would also like to have an example like the others in the config.yml. If you already have one, maybe you could add it. If not I will add one later.

corylulu commented 4 years ago

Awesome, I haven't worked with Kotlin / Gradle before, so I'm still trying to figure out how to compile, but I'm trying as well.

@corylulu cool! I hope you'll dive deeper into it. Kotlin is just awsome imho! Which IDE are you using? Maybe I can help with your compilation problems.

I installed the IntelliJ IDE, but yeah, I'm still unsure how to compile it into a .jar

flokol120 commented 4 years ago

@corylulu Alright, that is what I am using too. I must have used kotlin and gradle too much to not think about this being a problem for 'newbies'. I will add a small how-to to the readme (as soon as I have time for that), instructing how to setup artifacts in IntelliJ.

flokol120 commented 4 years ago

Thanks again for the cool feature! I will go ahead and merge your work.

flokol120 commented 4 years ago

I will build a new version containing your changes tomorrow asap.

corylulu commented 4 years ago

@corylulu Alright, that is what I am using too. I must have used kotlin and gradle too much to not think about this being a problem for 'newbies'. I will add a small how-to to the readme (as soon as I have time for that), instructing how to setup artifacts in IntelliJ.

Yeah, it says it builds fine, but the only .jar it produces is only 71kb's and doesn't contains all the stuff seen in your .jar... I wonder if I can just merge the two together tho.

Edit: Yeah, merging the two seems to have worked