search

flokol120 / Spigot-Item-Chest-Sorter

A Spigot/Paper minecraft plugin to sort your messy items into separate chests | 💯% written in Kotlin
GNU General Public License v3.0
5 stars 6 forks source link

Changes `.containsMatchIn()` to `.matches()` for better compatibility #3

Closed corylulu closed 4 years ago

corylulu commented 4 years ago

Retroactively, I realized I should always be matching the entire word, otherwise non-regex sets won't always work as expected unless everything has a ^ and $ added to both ends of it.

corylulu commented 4 years ago

Side note: I'm trying to figure out how easily I can add Barrels to work with this plugin. Initially my thinking is that it should be pretty easy, but before I dive to deep into it, is there anything extra I'd need to do that I might miss?

flokol120 commented 4 years ago

Side note: I'm trying to figure out how easily I can add Barrels to work with this plugin. Initially my thinking is that it should be pretty easy, but before I dive to deep into it, is there anything extra I'd need to do that I might miss?

Should be fairly easy. But I didn't thought about barrels yet. Maybe open an issue addressing this feature request

flokol120 commented 4 years ago

@corylulu If you can merge on your own, go ahead and do it (I do not know if the default repo settings allow this).