Broken focus field for non image file types

flokosiol / kirby-focus

Better image cropping for Kirby CMS

184 stars 14 forks source link

Broken focus field for non image file types #27

Closed ghost closed 6 years ago

ghost commented 6 years ago

Thank you very much for your field! It is a nice addition to the Kirby universe. 👍

I wanted to ask if it is normal for non-image fields to show a broken focus field? Maybe we can hide the field based on the supported mime types?

flokosiol commented 6 years ago

Thanks for reporting.

In previous versions there was a $file->canHaveThumb() Kirby core method which did the check, but it seems to be deprecated. I will push a fix to the development branch in a minute. Would be awesome, if you could check it!?

flokosiol commented 6 years ago

https://github.com/flokosiol/kirby-focus/archive/develop.zip

ghost commented 6 years ago

The dev version of the plugin fixes the problem!

flokosiol commented 6 years ago

Great. Thanks for testing. I will try to release a new version as soon as possible.