search

flokosiol / kirby-focus

Better image cropping for Kirby CMS
184 stars 14 forks source link

fixed full composer setup #34

Closed mcbrwr closed 5 years ago

mcbrwr commented 5 years ago

wasn't working because the autoloader was loaded twice. In this setup it works both from zipfile & with composer.

flokosiol commented 5 years ago

Thanks for the pull request. This whole composer stuff is completely new to me, so any help is appreciated 👍

mcbrwr commented 5 years ago

well, I can relate :-) I'm glad I have helpful colleagues. Together we can do this!

On 18 Jan 2019, at 17:57, Flo Kosiol notifications@github.com wrote:

Thanks for the pull request. This whole composer stuff is completely new to me, so any help is appreciated 👍

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/flokosiol/kirby-focus/pull/34#issuecomment-455615224, or mute the thread https://github.com/notifications/unsubscribe-auth/ABlcVnMGRW5Kxg4ndkhXR7D7Us_SdsbQks5vEfz5gaJpZM4aH4Kb.

flokosiol commented 5 years ago

I had a quick look at the official plugin documentation and it seems that the index.php should require autoload.php 🤔

Also some other plugin devs like @bnomei or @sylvainjule use the same folder setup. To be honest I'm more confused than before …

bnomei commented 5 years ago

@flokosiol my plugin setup will only work if you create a zip to be extracted into the site/plugin folder (see my composer.json zip script). but i think its a well working one to do composer/packagist and zip setup. @omz13 has similar setup but different zip skripts.

flokosiol commented 5 years ago

Thanks @bnomei – I used your zip script as a guideline and it seem to work fine.

@mcbrwr It would be awesome, if you could test the latest zip. For me everything worked fine. But if you'll run into any problems don't hesitate to re-open this issue or create a new one.