search

flokosiol / kirby-focus

Better image cropping for Kirby CMS
184 stars 14 forks source link

Plugins stretches/rotates images with certain EXIF settings #50

Closed jonasfeige closed 4 years ago

jonasfeige commented 4 years ago

Not sure if this is jut me, but when using the focus plugin, uploaded images with certain EXIF rotation settings get rotated/stretched.

Step to reproduce

  1. Download EXIF orientation sample images from this repo: https://github.com/recurser/exif-orientation-examples
  2. Download and setup Kirby Starterkit: https://github.com/getkirby/starterkit
  3. Login to the panel and navigate to any album (e.g. Photograph->Trees)
  4. Upload the sample photos, everything should work as expected
  5. Download and install the Focus plugin
  6. Delete the sample photos or navigate to another album
  7. Upload the sample photos again, numbers 5-8 will be stretched and/or rotated in the wrong way

I fixed this with a hook in the meantime.

flokosiol commented 4 years ago

First of all, thanks for this excellent description!

I went through the steps and ended up at no. 4 because the photos 5-8 already get stretched on a fresh starterkit installation without any additional plugins – at least for me. Pleaser find attached the screenshots from the Panel.

Starterkit 3.3.5 ImageMagick 7.0.10-6_1

The ImageMagick class used by the Focus plugin is almost the same as the one used by Kirby. So this issue might be Kirby related, @bastianallgeier!?

stretched-images-1 stretched-images-2
jonasfeige commented 4 years ago

Ah, interesting! I first thought it might be a Kirby issue as well but could then only reproduce it with the Focus plugin. Have you tried if the auto-orient setting for thumbs has any effect? It didn’t for me, unfortunately.

flokosiol commented 4 years ago

Auto-orient had no effect for me, too.

I close the issue for now as it seem to be Kirby related. If you run into any issues with this plugin again, don't hesitate to contact me again!