search

flokosiol / kirby-focus

Better image cropping for Kirby CMS
184 stars 14 forks source link

Make available for Kirby v.3.8.x #69

Closed renestalder closed 2 years ago

renestalder commented 2 years ago

I would like to introduce a change to the dependency range of Kirby versions to allow the installation in greater versions than the one defined. That puts the responsibility on the user to check for plugin compatibility. At the same time, also allows testing it with beta/rc versions early on.

flokosiol commented 2 years ago

Thanks for the suggestion @renestalder and the PR.

I did not test the Focus plugin with Kirby 3.8 yet. Did you have a look? If it works for you I would merge the request immediately 😉

renestalder commented 2 years ago

@flokosiol As far as I can tell, flawlessly.

I also don't understand why I was now able to install it in the stable release of Kirby 3.8, while it yielded a composer conflict before.

flokosiol commented 2 years ago

I had a short look at the composer constraints and I think the current one >=3.6 should work – even for new Kirby dev Versions!?

https://getcomposer.org/doc/articles/versions.md#stability-constraints

renestalder commented 2 years ago

@flokosiol I guess you mean the current one ^3.6. Yes, I guess it should update to minor versions without issues. Though I can't say why it showed a conflict for RC versions and why that made it not possible to install with the release candidates. However, it seems to work after the stable release so I consider it unnecessary to change anything.

flokosiol commented 2 years ago

Argh. Sorry, I mixed things up 🤪