Closed johannschopplich closed 3 years ago
Hey there!
Great work. I have some suggestions mainly to simplify scripts:
APP_ENV
mode
__dirname
process.cwd()
.lock
Hope those changes appeal to you.
Thanks again for your contribution, Johann.
Can't emphasise enough how much I learned from doing Open Source stuff :)
Dito, learning a lot myself here. Have a great day!
Hey there!
Great work. I have some suggestions mainly to simplify scripts:
APP_ENV
can be substituted with Vite'smode
key – available when export not an config object but an config funciotn__dirname
isn't available in type module Node projects (which I always use), therefore useprocess.cwd()
.lock
file, don't create it every time the app is builtHope those changes appeal to you.