Simplify package.json and vite config

flokosiol / kirby-vitekit

Vite.js + Kirby 3 with public folder setup

MIT License

42 stars 0 forks source link

Closed johannschopplich closed 3 years ago

johannschopplich commented 3 years ago

Hey there!

Great work. I have some suggestions mainly to simplify scripts:

APP_ENV can be substituted with Vite's mode key – available when export not an config object but an config funciotn
__dirname isn't available in type module Node projects (which I always use), therefore use process.cwd()
force deletion of .lock file, don't create it every time the app is built

Hope those changes appeal to you.

flokosiol commented 3 years ago

Thanks again for your contribution, Johann.

Can't emphasise enough how much I learned from doing Open Source stuff :)

johannschopplich commented 3 years ago

Dito, learning a lot myself here. Have a great day!