Vite plugin refactor - Githubissues

flokosiol / kirby-vitekit

Vite.js + Kirby 3 with public folder setup

MIT License

42 stars 0 forks source link

Vite plugin refactor #2

Closed johannschopplich closed 3 years ago

johannschopplich commented 3 years ago

Edit: Please merge https://github.com/flokosiol/kirby-vitekit/pull/1 first.

I've made some minor improvements to your Vite plugin:

F::exists returns a bool, thus no need for if statement
Raise exception if build assets not found (detected through manifest's presence or absence)
Improve readability (from my point of view)
Fix case of namespace

I hope those sound fine to you. 🙂