search

flomesh-io / fsm

Lightweight service mesh for Kubernetes East-West and North-South traffic management, uses ebpf for layer4 and pipy proxy for layer7 traffic management, support multi cluster network.
https://flomesh.io
Apache License 2.0
50 stars 7 forks source link

fix: incorrect update annotation of FLB svc #173

Closed reaver-flomesh closed 5 months ago

reaver-flomesh commented 5 months ago

Description:

Testing done:

Affected area: Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?

    • Did you notify the maintainers and provide attribution?

  2. Is this a breaking change?

  3. Has documentation corresponding to this change been updated in the fsm-docs repo (if applicable)?

codecov-commenter commented 5 months ago

Codecov Report

Attention: 311 lines in your changes are missing coverage. Please review.

Comparison is base (1eeee08) 47.58% compared to head (69ff23e) 46.81%. Report is 2 commits behind head on release/v1.2.

Files Patch % Lines
cmd/cli/connector_enable.go 6.71% 235 Missing and 1 partial :warning:
cmd/cli/connector_disable.go 30.00% 34 Missing and 1 partial :warning:
cmd/cli/util.go 0.00% 11 Missing :warning:
cmd/cli/egressgateway_enable.go 0.00% 9 Missing :warning:
pkg/sidecar/providers/pipy/registry/services.go 0.00% 7 Missing :warning:
pkg/providers/kube/client.go 69.23% 4 Missing :warning:
cmd/cli/flb_enable.go 0.00% 3 Missing :warning:
cmd/cli/ingress_enable.go 0.00% 3 Missing :warning:
pkg/k8s/client.go 0.00% 3 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release/v1.2 #173 +/- ## ================================================ - Coverage 47.58% 46.81% -0.77% ================================================ Files 196 199 +3 Lines 14884 15229 +345 ================================================ + Hits 7083 7130 +47 - Misses 7757 8053 +296 - Partials 44 46 +2 ``` | [Flag](https://app.codecov.io/gh/flomesh-io/fsm/pull/173/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/flomesh-io/fsm/pull/173/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `46.81% <14.79%> (-0.77%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.