search

flomesh-io / pipy

Pipy is a programmable proxy for the cloud, edge and IoT.
https://flomesh.io/pipy
Other
776 stars 73 forks source link

[ci]: use llvm-toolset-7.0-clang instead of clang on el7 #132

Closed tchaikov closed 1 year ago

tchaikov commented 1 year ago

as llvm-toolset-7.0-clang does not provide clang, let's BuildRequires it directly.

Signed-off-by: Kefu Chai tchaikov@gmail.com

We thank you for helping improve Pipy. In order to ease the reviewing process, we invite you to read the guidelines and ask you to consider the following points before submitting a PR:

  1. We prefer to discuss the underlying issue prior to discussing the code. Therefore, we kindly ask you to refer to an existing issue, or an existing discussion in a public space with members of the Core Team. In few cases, we acknowledge that this might not be necessary, for instance when refactoring code or small bug fixes. In this case, the PR must include the same information an issue would have: a clear explanation of the issue, reproducible code, etc.

  2. Focus the PR to the referred issue, and restraint from adding unrelated changes/additions. We do welcome another PR if you fixed another issue.

  3. If your change is big, consider breaking it into several smaller PRs. In general, the smaller the change, the quicker we can review it.

keveinliu commented 1 year ago

Thanks for your quick response! Cheers, Kevein