search

floodlight-sports / floodlight

Python package for streamlined analysis of sports data.
https://floodlight.readthedocs.io/en/latest/index.html
MIT License
59 stars 14 forks source link

Develop #130

Open hbiermann95 opened 1 year ago

hbiermann95 commented 1 year ago

Replace attributes ["key"] with attributes .get("key", None) to circumvent errors when "key" is not in the event attributes dictionary.

draabe commented 1 year ago

Hi @hbiermann95 , looks like a sensible fix. Would you mind refactoring so that it passes all checks?

codecov[bot] commented 1 year ago

Codecov Report

Merging #130 (f01e540) into develop (22cb3a2) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #130   +/-   ##
========================================
  Coverage    95.58%   95.58%           
========================================
  Files           47       47           
  Lines         3194     3194           
========================================
  Hits          3053     3053           
  Misses         141      141
Files Changed Coverage Δ
tests/test_core/test_definitions.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more