search

floodlight / bigcode

Other
11 stars 47 forks source link

OF-DPA ORC driver #58

Closed rizard closed 6 years ago

rizard commented 9 years ago

@capveg

Working on an OF-DPA driver for ORC. Does not compile and has not been tested -- this commit is just for documentation purposes and for potential feedback.

I'm still actively working on it and will make other commits in the near future as I progress.

bsn-abat commented 9 years ago

ABAT: AUTO-REJECT: no reviewer specified in pull request description

INSTRUCTIONS: Please fix your problem by

1) Make sure line below is included in pull request description (not a follow-up comment): Reviewer: @exampleuser1 @exampleuser2 @exampleuser3 ... Leave no space at beginning of line. Use real GitHub IDs as reviewers.

2) Have at least one approval in any follow-up comment. An approval is given by including a single word of "ACK" (without quotes) in a line by itself. The approval can come from any person except the requester.

Under certain situations the requester can approve his/her own change. To do that, just include a single word of "SELF-ACK" (without quotes) in a line by itself. You are trusted not to abuse it :)

Any code review approval or new comment including the magic line of "R_E_T_R_Y" (Remove the underscores) will cause abat to automatically try to merge your code again.

capveg commented 8 years ago

@rizard : is this code ready for review or do you want more time with it?

rizard commented 8 years ago

@capveg I just pushed another round of updates. Adding and removing an interface works now.

I need to handle a route with a kernel next hop correctly -- working on it now. The driver ignores that next hop now, but it should insert flows into the unicast routing and policy ACL tables to direct all packets to the kernel.

I assume this kernel next hop in the route will be updated with the real next hop's MAC after the kernel learns the next hop MAC through ARP.

rizard commented 8 years ago

@capveg Feel free to take a look and let me know if there's anything obvious I need to rework. I haven't condensed anything yet, so there is repetition in places that I'll form into functions.

Adding and removing interfaces, routes, and next hops appears to be working (by observation of flow and group tables before/after ifconfig and route operations). I need to run now, but I'll try and test out with a real "next hop" using wiremonkey to check if the kernel next hop flows are indeed replaced with real next hop flows.