search

floodlight / loxigen

OpenFlow protocol bindings for multiple languages
96 stars 130 forks source link

Meter band header incorrect #457

Open rizard opened 8 years ago

rizard commented 8 years ago

I believe the header does include all four of these fields:

https://github.com/floodlight/loxigen/blob/master/openflow_input/standard-1.3#L1172

as defined on page 70 of the spec here:

https://www.opennetworking.org/images/stories/downloads/sdn-resources/onf-specifications/openflow/openflow-spec-v1.3.1.pdf

There is an error parsing a valid meter config stats reply from a switch. The reply is defined on page 87 of the spec and includes the header which should have 4 fields.

There is an ongoing issue in Floodlight where the controller has difficulty parsing a meter config stats reply (but does fine parsing plain meter and meter features replies). I think this meter band header is the root of the problem, but I haven't had a chance to look into it deep enough yet.

rizard commented 8 years ago

Note that this should also be changed in OF1.4.