floooh / fips-bgfx

fipsified version of bgfx (https://github.com/bkaradzic/bgfx)
17 stars 8 forks source link

Changes bgfx_app to be a function #12

Closed fungos closed 8 years ago

fungos commented 8 years ago

Fixes some dependencies to be imported when importing fips-bgfx; Adds a helper macro to include bx compat headers.

floooh commented 8 years ago

Out of interest, what problem happened with bgfx_app being a macro vs function?

floooh commented 8 years ago

did quick test on OSX: no problems

fungos commented 8 years ago

The parameters of a macro aren't variables, so "name" failed the test if (NOT name). Also, if we do not need to set anything to the global scope, it is preferable to use a function. ;)