search

floooh / fips

High-level build system for distributed, multi-platform C/C++ projects.
MIT License
468 stars 82 forks source link

cmake.py/run_build() adds Visual Studio args for Android builds #251

Open floooh opened 4 years ago

floooh commented 4 years ago

See here:

https://github.com/floooh/fips/blob/2b42c3408088a8f3bf94789169183a868f33819d/mod/tools/cmake.py#L89

The code assumes that all builds on Windows are done with Visual Studio, and on all other platforms with a build tool which understands the -j option. Needs to be changed to check the build tool instead.

This produces problems like:

=== building: android-vscode-debug
cmake --build . --config Debug -- /nologo /verbosity:minimal /maxcpucount:10
ninja: error: unknown target '/nologo'
[ERROR] Failed to build config 'android-vscode-debug' of project 'X'