Closed kaffeewolf closed 2 years ago
Hmm yeah, that's sort of a known issue (https://github.com/floooh/fips/issues/270).
You could try "fixing" this line (remove the --parallel {}
and num_jobs
and see if this changes anything (I doubt it though - but if it does we could probably remove the --parallel when the Visual Studio generator is used):
https://github.com/floooh/fips/blob/master/mod/tools/cmake.py#L83
AFAIK MSVC has two types of parallelism, one between targets (which is probably what the --parallel
switch uses, and a separate switch /MP
(called "Multi-processor Compilation" in the Visual Studio options.
The /MP
flag is activated in the Windows "toolchain file" used by fips, here:
...and here:
...so I would expect that building within a single target is also parallelized.
I noticed this today as well, in my project building with --parallel takes 34s and without 13s. Building with msbuild directly takes 12s.
Building inside the VS IDE is even faster for some reason, around 9s for this project.
Closing this because of PR #289.
Not really a fips issue, probably more like a CMake issue, but the switch to using
cmake build --parallel
in 3a55aa3472014b448fabb9f33a07f1b043bf3ae2 results in poor build times when using fips build from the commandline on Windows with MSVC. It appears the build is parallel per project only, so having a large project and a lot of small ones will become very slow as the large project is built on a single core only. In my case build times went from 110s to > 300 (thats when i aborted).Building in Visual Studio it seems to work fine however.