search

floooh / fips

High-level build system for distributed, multi-platform C/C++ projects.
MIT License
471 stars 82 forks source link

MSVC 2019 doesn't identify linker flag when lower-case #280

Closed mattiasljungstrom closed 2 years ago

mattiasljungstrom commented 2 years ago

This is really a minor inconvinience but I noticed this when I was fixing the last issue.

MSVC 2019 will put '/machine:x64' in "Additional Options" unless it's in upper-case. I have not tested this on other MSVC versions, and I guess it might be an issue if people check for "x64" in their project in FIPS_WINDOWS_PLATFORM_NAME.

floooh commented 2 years ago

Hmm, where do you see this "Additional Options", I only see the setting here under "Target Machine":

image

(this is VS2019 Version 16.11.9)

Should the "x86" also be capitalized? In the settings dialog it's /MACHINE:X86.

I don't think (or rather: hope) FIPS_WINDOWS_PLATFORM_NAME is used much outside the toolchain file.

mattiasljungstrom commented 2 years ago

Under "Command Line", on the bottom. (In the Linker settings)

mattiasljungstrom commented 2 years ago

x86 should perhaps also be upper-case, I don't know if I have any 32-bit projects to test with. :)

mattiasljungstrom commented 2 years ago

I changed x86 to X86.

floooh commented 2 years ago

Ok merged, thanks! :)