floooh / fips

High-level build system for distributed, multi-platform C/C++ projects.
MIT License
471 stars 82 forks source link

remove --parallel flag on windows builds #289

Closed mattiasljungstrom closed 2 years ago

mattiasljungstrom commented 2 years ago

A quick fix for issue #273. Compilation is much faster without --parallel flag.

floooh commented 2 years ago

Thanks! It would be more robust to check for the cmake generator instead of the host platform, but since non-MSVC builds on Windows are probably quite rare the fix still makes sense :)

mattiasljungstrom commented 2 years ago

I figured out the difference between VS IDE and msbuild setup, need to pass the -m flag to msbuild to get same performance. You can do this by passing it on the end to cmake: "cmake --build . --config Debug -- -m".

This is supported by at least back to VS2017, maybe further back. Not sure how to best check if generator is MSVC, so for now I'll do "./fips build -- -m". This reduces build time from 14s to ~8s for my current project.