Closed rdroe closed 5 years ago
That was a recent change in the ImGui API (I think the new flags have been in for quite a while, but the old flags stayed in for backward compatibility, and those have been removed recently).
Thanks a lot for the PR! I just merged that.
Thanks again for Oryol!
I could be doing something wrong, but following the README.md exactly, I get errors during an
osx-xcode-debug
fips build. Some build error messages are included at end of this text, but I think I found the solution.It seems that some imgui breaking changes are breaking some of these samples.
https://github.com/rdroe/oryol-samples/tree/imgui-updates gets past my build errors. I have also done quick manual checks of each previously broken demo, and it seems all right in the branch just mentioned.
If I'm right, the relevant ImGui updates are mentioned in the Api Breaking Changes section around https://github.com/ocornut/imgui/blob/62143dff64c8cfb960248b84cf6c4566ffc5a743/imgui.cpp#L374 (with further references mentioned there).
ImGui::IsMouseHoveringAnyWindow() --> ImGui::IsWindowHovered(ImGuiHoveredFlags_AnyWindow) ImGuiSetCond_Once --> ImGuiCond_Once ImGuiSetCond_FirstUserEver --> ImGuiCond_FirstUseEver
Error text
Also
And one more is like the first, but the constant is named
ImGuiSetCond_FirstUseEver
, needing to change toImGuiCond_FirstUseEver
(but please double-check the branch with all the tests you know of).