search

floooh / oryol-samples

Oryol extension module samples
MIT License
82 stars 16 forks source link

Fixes for API breaking changes in imgui 1.74. #18

Closed ghost closed 4 years ago

ghost commented 4 years ago

See: https://github.com/ocornut/imgui/blob/master/imgui.cpp#L394

I've never used github before, so this is my first attempt at creating a pull request.

floooh commented 4 years ago

Thanks for the PR!

I think the ImGui::SetNextWindowSize() needs to go before the ImGui::Begin().

(I wasn't actually sure if the order matters, but when I tried it your way in the Fractal sample the window size came out wrong, it looks correct if the call to SetNextWindowSize() is moved above the Begin() call).

Do you want to fix this before merge? Otherwise I can also fix it "post-merge".

ghost commented 4 years ago

Woops, I'll fix it.

floooh commented 4 years ago

Thanks!