floooh / sokol-samples

Sample code for https://github.com/floooh/sokol
MIT License
611 stars 79 forks source link

Need to have a make.exe in the PATH when building android samples under Windows #136

Open llzen44 opened 6 months ago

llzen44 commented 6 months ago

Hi

There is still a need to have make.exe available in the PATH when building android examples under Windows (10). I tend to have as few as possible in my PATH by default (unlike *nix systems).

Once using the one under fips-sdks\android\ndk-bundle\prebuilt\windows-x86_64\bin, everything is built correctly.

error msg: [ERROR] build tool(s) make not found

merci

floooh commented 6 months ago

I'm not sure if cmake is smart enough to find the make tool inside the android-sdk directory, but it's worth a try I guess.

To try this, you can go into the fips directory and change this function to always return True:

https://github.com/floooh/fips/blob/master/mod/tools/make.py#L12

If the build then works we can easily remove the requirement that make is in the path, otherwise there's not much that can be done I guess.

What I do to prevent PATH pollution on Windows is to install any cmdline tools via scoop: https://scoop.sh/, scoop only adds a single new directory to the PATH, and then puts links to all installed command line tools into this directory.

I would also recommend the ninja tool instead of make (https://bjansen.github.io/scoop-apps/main/ninja/).