floooh / sokol-tools

Command line tools for use with sokol headers
MIT License
229 stars 57 forks source link

Correct HandmadeMath.h type capitalization in sokol-shdc.md #102

Open danielchasehooper opened 1 year ago

floooh commented 1 year ago

Hmm, this is actually wrong though? Those capitalized names are constructor functions, not typenames (e.g. see: https://github.com/floooh/sokol-samples/blob/578d71daed073dbeb2e5e3d74a3485cf46733cd7/sapp/HandmadeMath.h#L526)

PS: ah looks like this is a change from HandmadeMath "version 2":

https://github.com/HandmadeMath/HandmadeMath/blob/6cf6226c57fcb083d713b9b5e5e8cde14edb7075/HandmadeMath.h#L222

...I'm not planning to update to this latest version anytime soon though (I'll probably create a sokol_math.h header instead).

I'll set the PR to draft, but will keep it open until I made a decision whether I'll update the sokol-samples to the latest HandmadeMath.h headers or not.