Closed colinbellino closed 1 month ago
Ah thanks, very cool! I added two comments, see above.
@NEO97online I guess/hope you are ok with these changes?
Thanks for the change! I'll wait a bit to give @NEO97online an opportunity to respond, and will probably merge tomorrow evening.
Yeah, there is no rush.
It wasn't really my intent to change this much code, but it didn't feel right by me to keep a version on the main branch that broke like that, hopefully that's alright with @NEO97online!
Ok merged, thanks for the fixes!
Binaries will be uptodate when this CI pipeline goes green: https://github.com/floooh/sokol-tools/actions/runs/10270309931
Thanks!
Since i know you don't have access to the beta, i made some tests and can confirm the binaries above work on the following versions (3 latests):
Thanks for these fixes @colinbellino ! I was surprised to find that my PR was already merged, this is awesome. I made it for myself in a bit of a hurry and wanted to share, looks like I left some of my own type aliases in there.
Great improvements!!
I noticed a lot of small issues with the initial PR that merged the code generator for Jai (ie: it doesn't compile), so i though i'd open a PR for the fixed since i've been using a private fork for a while.
The current version in master had invalid syntax so i'm assuming the author used the syntax of Odin (or another) and forgot to replace some of the things. I compiled the SDF.glsl file from the samples to show the differences in output to save some time.
Most issues were
,
instead of;
and struct padding issues and i also removed the#scope_module
since that's the default.I've a comment to explain why i don't think importing
sokol_gfx
is the right call at the moment, let me know what you think about this.I also have generated the bindings for sokol, if that's something you'd be interested in let me.
Current:
Fixed:
Edit: turns out, it's a huge pain to post text files inside a PR on GitHub and the editor is super laggy now, uh... Sorry for the mess.