Closed allcreater closed 4 weeks ago
Yeah pretty sure that's a bug. Let me try to find out why that happened...
Yeah it's clearly a bug, sorry about that. For instance in the C generator it looks correct (same as your fix):
Merged. Thanks for the fix! I'll add a quick blurb to the changelog and then start a CI pipeline to update the binaries.
Ok, binaries will be uptodate when this CI pipeline goes green: https://github.com/floooh/sokol-tools/actions/runs/10374632850
Hi!
I finally got around to updating sokol, everything is great (and a huge thank you and the community for these amazing improvements!!), but unfortunately I found a small problem with sokol-shdc, or more precisely with YamlGenerator.
The thing is that it generates incorrect reflection for the flattened uniform blocks.
For example, consider the original structure:
In GLSL 410 it is transformed into the following form:
The generator works like this:
Previously it worked like this, and it seems that this behavior (which began to change in fd9a675db) was IMHO more correct:
I would like to propose to return the original behavior, that is, reflect uniform block as if it consists of a single array field, having the name of the block itself.
If such changes were made intentionally, I suggest expanding the output, leaving all members of the block, and adding a flag that the block is flattened, or something like that :)