Closed jakubtomsu closed 7 months ago
Linked PR from the sokol-odin repo: https://github.com/floooh/sokol-odin/pull/11
It's a pretty big PR, so in case you don't like something let me know
Looks good! I'll try to give it a whirl on the weekend before merging.
I was wondering why you moved the top-level scripts to build the C libraries into a subdirectory (because I preferred to have them visible at the top level), but this is a good reason:
This means the sokol folder is now completely standalone and can be easily copied into the source directory of any project.
PS: don't worry about the failed CI, I guess that's because the PR expects the new directory structure in sokol-odin.
Thank you! I agree the build scripts look nicer in the top-level folder, but this way just fits the odin workflow a bit better...
And merged. Many thanks!
This PR does a number of modifications to the Odin binding generator, and the project structure:
sokol.c
for unity builds#config
values as constants, so they can be easily used elsewhereODIN_DEBUG
(which is still used by default), which can override either all sokol libs or individual modulesc
folder which contains all C files and the build scripts into thesokol
folder with odin packages. This means thesokol
folder is now completely standalone and can be easily copied into thesource
directory of any project.Most of these changes are what I used in my game Solar Storm. Sometimes it's just what I personally prefer, but I think it ultimately does make the bindings easier to work with.