search

floooh / sokol

minimal cross-platform standalone C headers
https://floooh.github.io/sokol-html5
zlib License
6.82k stars 475 forks source link

use addr instead unsafeAddr #846

Closed Angluca closed 1 year ago

Angluca commented 1 year ago

warning:: unsafeAddr is a deprecated alias for addr use addr instead.

floooh commented 1 year ago

Nice! Will try to take care of this and the PR in sokol-nim over the weekend.

floooh commented 1 year ago

Ok, same NIm version compatibility problem in the CI pipeline like in https://github.com/floooh/sokol-nim/pull/21#issuecomment-1604483680.

Can you try upgrade the nim-version here?

https://github.com/floooh/sokol/blob/177e2c79bee74acebaeeb8d5b29f7f168858ff78/.github/workflows/gen_bindings.yml#L128

floooh commented 1 year ago

...hmm, no idea what's going wrong there in the Nim setup...

Angluca commented 1 year ago

I test nim_version: devel is ok (devel is v1.9+, nim will upgrade to v2.0 at next year) Wait until tomorrow It will succeed (see sokol-nim :)

floooh commented 1 year ago

Ok merged, thanks for the PR!