floooh / sokol

minimal cross-platform standalone C headers
https://floooh.github.io/sokol-html5
zlib License
6.63k stars 472 forks source link

fix errant framebuffer bind #878

Closed danielchasehooper closed 10 months ago

danielchasehooper commented 10 months ago

the framebuffer was getting bound even when msaa hadn't changed it

floooh commented 10 months ago

Oops yeah looks like a bug. This was a "fix" for a rendering corruption problem on Chrome on Windows (https://bugs.chromium.org/p/chromium/issues/detail?id=1453425)

I'll need to check whether the "fix" was actually only working because it contained this bug. I'll try to look into this today (only downside is I have no Windows machine for testing around today).

Thanks for the PR!

floooh commented 10 months ago

Ok tested (only on my Mac though) and merged. Many thanks!