floooh / sokol

minimal cross-platform standalone C headers
https://floooh.github.io/sokol-html5
zlib License
7.12k stars 501 forks source link

Change getRawX to getX on the Android #974

Closed Comanx closed 10 months ago

Comanx commented 10 months ago

If use the getRawX getRawY method in multi-window mode on the Android platform, it will not accurately correspond to the touch position of the current window.

floooh commented 10 months ago

Thanks! I'll check if getX() etc... returns the same values for the "single window case" in the sokol samples and then merge.

floooh commented 10 months ago

Btw, if you create your pull requests from a dedicated and uniquely named branch (not your master branch) you'd be making my life a tiny bit easier ;)

(for future PRs)

floooh commented 10 months ago

Looking good and merged. Thanks!

I'll also add a small changelog entry.

Comanx commented 10 months ago

Btw, if you create your pull requests from a dedicated and uniquely named branch (not your master branch) you'd be making my life a tiny bit easier ;)

(for future PRs)

Got it, will use unique branch for future PRs. Thanks!