floooh / v6502r

visual6502 remixed
310 stars 32 forks source link

Light theme #5

Open verhovsky opened 1 year ago

verhovsky commented 1 year ago

Can you add a theme with a white background please?

Here's some suggestions for the colors (red green blue) from https://ai.eecs.umich.edu/people/conway/VLSI/VLSIText/PP-V2/V2.pdf page 215

rgb(102, 156, 124)
rgb(105, 188, 232)
rgb(207, 87, 129)

I used this svg file to color match https://4004.com/4004-50th-1st-cut-svg.html

floooh commented 1 year ago

I've been updating the colors palettes, and added a new theme called 'Contrast', which is essentially the original Visual6502 color theme with a white background, not live yet, but soon-ish.

Screenshot 2023-01-12 at 20 04 08
verhovsky commented 1 year ago

Thank you. Could you make the background pure white please?

verhovsky commented 1 year ago

Gonna close this, I can set it to pure white locally now, if you prefer the grey.

floooh commented 1 year ago

Is there a specific reason why you need it pure white btw?

In any case the new palette is defined here (the last entry with 0.8 is the background color):

https://github.com/floooh/v6502r/blob/c2f1a61c62af9fd5e1431cbcde253174af6a56e3/src/ui.cc#L755-L767

...or if you want to override the default palette, that's defined here now:

https://github.com/floooh/v6502r/blob/c2f1a61c62af9fd5e1431cbcde253174af6a56e3/src/gfx.h#L20-L30

floooh commented 1 year ago

FYI: I'm going to change the background color of the Contrast theme to white, will upload the WASM version some time this evening.

verhovsky commented 1 year ago

Could you please set imgui to light colors when selecting the Contrast theme as well? You already have some (presumably unused) code related to this here

https://github.com/floooh/v6502r/blob/188d90f735f5f200346a606720d577375f504f54/ext/chips/ui_util.h#L178

P.S. I think "Light" would be a much better name than "Contrast".