Missing Subscreen Delay Fix in multiple versions of Ocarina of Time [Includes Patch]

[GoogleCodeExporter]

Describe your system:
 - Operating System (be specific): Peppermint 4 (Ubuntu 13.04)
 - Machine type (32-bit or 64-bit): 64-bit
 - Mupen64Plus version: Latest from hg
 - Plugins used: Irrelevant.  Defaults + Glide64Mk2

For visual artifacts, give:
- game name and CRC/MD5 hash (printed on console)
- description of the artifact (missing polygons, flashing, wrong colors,
etc)

Describe the problem:
src/main/cheat.c contains built-in cheats for Ocarina of Time, which activates 
the essential subscreen delay fix.  However, the built-in code for Master Quest 
only works for the (E) version of Master Quest, and not the (U) version.  The 
file also does not include the (U) (GC) version of Ocarina of Time.
Master Quest and the GC versions of Ocarina of Time also need the End Credits 
Fix, otherwise these games will crash when the credits are displayed.

Please provide any additional information below.

Attached is a patch which refactors this portion of cheat.c while adding codes 
for all GC Versions of Ocarina of Time.  The codes were sourced from Project 64 
2.1's rdb.  Not all have been tested, but I can confirm the Standard and Master 
Quest (U) (GC Version) roms are working perfectly now.  It should cleanly apply 
to the latest hg version without issue.  If not accepted outright, I imagine 
this patch should get you started.

Original issue reported on code.google.com by iLagDoes...@gmail.com on 9 Dec 2013 at 6:53

Attachments:

• OcarinaFix.patch

[GoogleCodeExporter]

What should I use as Author+E-Mail of this patch?

Original comment by s...@narfation.org on 11 Dec 2013 at 9:12

[GoogleCodeExporter]

Author:  Joel "iLag" Hammond
E-mail:  iLagDoesntCheckThisEmail@gmail.com

Original comment by iLagDoes...@gmail.com on 12 Dec 2013 at 6:50

[GoogleCodeExporter]

Thanks. I will submit this patch to Richard with the next pull request

Original comment by s...@narfation.org on 13 Dec 2013 at 12:33

[GoogleCodeExporter]

Pullrequest was merged

Original comment by s...@narfation.org on 14 Dec 2013 at 12:20

• Changed state: Fixed