search

flopp / GpxTrackPoster

Create a visually appealing poster from your GPX tracks
MIT License
411 stars 50 forks source link

Move setup instruction to top and improve Dockerfile #113

Closed thorian93 closed 4 weeks ago

thorian93 commented 4 weeks ago

It took me an embarrassing amount of time to find the setup instructions.

So I merely propose to put the setup instructions on the top of the README, like most projects do.

Due to my not being too used to GitHub, I accidentally added some changes to the Dockerfile in this PR.

Before cleaning things up, @flopp please do let me know if this is something that you would be interested in. Then I will gladly proceed and work on the container topic and polish it.

flopp commented 4 weeks ago

Thank you for improving the situation. Your changes look good, I will merge them as-is.

flopp commented 4 weeks ago

If you want to continue with containers, please go ahead - I don't have much experience in this area.

thorian93 commented 4 weeks ago

Nice, that provides me with the necessary motivation to go even a little further. Thanks! Do you use any containerization here currently? If not, I would go ahead and clean up even further.

Love the project by the way! Exactly what I need to show off my Inline Skating. :muscle: :grin: