Closed yihong0618 closed 3 years ago
why my black
is different.....
Did you run black --line-length 120
(e.g. via make format
)?
Did you run
black --line-length 120
(e.g. viamake format
)?
@flopp
Yes.... Its the black version and pylint version problem...
can you add version in requirement? why the pr
finish?
Finally!!!!
@flopp
I only have +8 timezone...can you also take a test on github
and others poster for the datetime ?
Works fine for my local +2 timezone!
@yihong0618, could you please squash the 9 commits into one? Then I can merge the PR...
@flopp done! Please check~
I will change the code to always adjust UTC timestamps to the timezone based on their lat/lng, as this seems to make perfect sense in general. => --use-localtime
will also be removed...
I will change the code to always adjust UTC timestamps to the timezone based on their lat/lng, as this seems to make perfect sense in general. =>
--use-localtime
will also be removed...
I think you are right
@flopp seems that still 9 commits, I used rebase -i
and local commits change to 1, but seems that it is also 9 commits here.
Hm, ok. Doesn't really matter, I guess...
Hm, ok. Doesn't really matter, I guess...
~Sorry for that.
@yihong0618 when doing git rebase -i
did you use s
to squash commits ?
@yihong0618 when doing
git rebase -i
did you uses
to squash commits ?
yes...
Then you end up with just one commit ?
And you can git push -f
Then you end up with just one commit ?
And you can
git push -f
I just push not -f. I think this may caused it, Thank you very much~
@flopp fix: #54 and try to cache pip file in GitHub Action