flopp / GpxTrackPoster

Create a visually appealing poster from your GPX tracks
MIT License
412 stars 50 forks source link

add: use-localtime command to local time show #62

Closed yihong0618 closed 3 years ago

yihong0618 commented 3 years ago

@flopp fix: #54 and try to cache pip file in GitHub Action

yihong0618 commented 3 years ago

why my black is different.....

flopp commented 3 years ago

Did you run black --line-length 120 (e.g. via make format)?

yihong0618 commented 3 years ago

Did you run black --line-length 120 (e.g. via make format)?

@flopp

Yes.... Its the black version and pylint version problem...

can you add version in requirement? why the pr finish?

yihong0618 commented 3 years ago

Finally!!!!

yihong0618 commented 3 years ago

@flopp I only have +8 timezone...can you also take a test on github and others poster for the datetime ?

flopp commented 3 years ago

Works fine for my local +2 timezone!

@yihong0618, could you please squash the 9 commits into one? Then I can merge the PR...

yihong0618 commented 3 years ago

@flopp done! Please check~

flopp commented 3 years ago

I will change the code to always adjust UTC timestamps to the timezone based on their lat/lng, as this seems to make perfect sense in general. => --use-localtime will also be removed...

yihong0618 commented 3 years ago

I will change the code to always adjust UTC timestamps to the timezone based on their lat/lng, as this seems to make perfect sense in general. => --use-localtime will also be removed...

I think you are right

yihong0618 commented 3 years ago

@flopp seems that still 9 commits, I used rebase -i and local commits change to 1, but seems that it is also 9 commits here.

flopp commented 3 years ago

Hm, ok. Doesn't really matter, I guess...

yihong0618 commented 3 years ago

Hm, ok. Doesn't really matter, I guess...

~Sorry for that.

Djailla commented 3 years ago

@yihong0618 when doing git rebase -i did you use s to squash commits ?

yihong0618 commented 3 years ago

@yihong0618 when doing git rebase -i did you use s to squash commits ?

yes...

Djailla commented 3 years ago

Then you end up with just one commit ?

And you can git push -f

yihong0618 commented 3 years ago

Then you end up with just one commit ?

And you can git push -f

I just push not -f. I think this may caused it, Thank you very much~