flopp / GpxTrackPoster

Create a visually appealing poster from your GPX tracks
MIT License
411 stars 50 forks source link

add: from strava close #44 #73

Closed yihong0618 closed 3 years ago

yihong0618 commented 3 years ago
  1. I add a new cache for strava. I think its simple and different from old gpx cache.
  2. about time zone I used a tricky way

Please help me to review @flopp @Djailla Thank you very much.

flopp commented 3 years ago

Could you change the --from-strava option so that it takes the Strava authentication file as a parameter, e.g --from-strava my-strava.json? The current fixed file name strava.json that must exist in the current directory is not good, IMHO.

yihong0618 commented 3 years ago

Could you change the --from-strava option so that it takes the Strava authentication file as a parameter, e.g --from-strava my-strava.json? The current fixed file name strava.json that must exist in the current directory is not good, IMHO.

Thanks. of course I will change it right now.

And are there other suggestions?

yihong0618 commented 3 years ago

@flopp
Done, learned that git reabase -i need to git push -f

flopp commented 3 years ago

Ok, perfect. Thank you! I will merge the PR and try it out...

yihong0618 commented 3 years ago

Thank you.