search

flopp / GpxTrackPoster

Create a visually appealing poster from your GPX tracks
MIT License
426 stars 50 forks source link

Rename activity option #92

Closed lowtower closed 3 years ago

lowtower commented 3 years ago

This PR renames the option "activity" to "activity_type" to be more clear and consistent with other options. Additionally, this PR adds the filter "--activity-type" and other options to the README by running the script update-readme.

flopp commented 3 years ago

This could break some existing installations - maybe we should add an alias to be backwards compatible...

flopp commented 3 years ago

args_parser.add_argument(["--activity-type", "--activity"], ...) should work, I guess.

lowtower commented 3 years ago

To be honest, my initial PR was committed maybe a bit hastily. With this PR, I want to correct some (in my eyes) messy inconsistencies, which is rather cosmetic than really necessary. You are right, that this would break existing installations. It's Your tool - You decide which way to go. I am fine with both names as options (pushed with commit f27d93e)

flopp commented 3 years ago

Thank you!