floraison / fugit

time tools (cron, parsing, durations, ...) for Ruby, rufus-scheduler, and flor
MIT License
384 stars 34 forks source link

Specify which sidekiq-cron version is available #101

Closed ozachun closed 5 months ago

ozachun commented 5 months ago

Issue description

Stated in https://github.com/floraison/fugit?tab=readme-ov-file "Related projects - Similar, sometimes overlapping projects" of sidekiq-cron - recent versions of Sidekiq-Cron use fugit to parse cron strings

In the above description, it says that it is available in the recent versions of Sidekiq-Corn, but from which version is it available? Not stated.

スクリーンショット 2024-04-18 15 36 30

How to reproduce

version Booted Rails 7.0.7, Running in ruby 3.2.2, Sidekiq Pro 5.5.8 / Sidekiq Enterprise 2.5.3

The simplest piece of code that reproduces the issue, for example:

config.periodic do |cron|
  cron.register('0 5 * * mon#1', SampleWorker', 'args' => [])
end

bundle exec rails c

>  SampleWorker.perform_async()

Even though version of Sidekiq Pro 5.5.8 / Sidekiq Enterprise 2.5.3 is old. Executed, but did not run at the specified time.

I found out that the version of sidekiq-corn I was using was out of date.

Expected behaviour

In "Projects using fugit". Describe which version is executable.

jmettraux commented 5 months ago

Hello,

I contributed a switch from rufus-scheduler to fugit in 2018:

https://github.com/sidekiq-cron/sidekiq-cron/commit/ae9701beabed5bc0def9a28e12539d277771ef81

It's been six years.

jmettraux commented 5 months ago

Thanks for pointing that out!