floraison / fugit

time tools (cron, parsing, durations, ...) for Ruby, rufus-scheduler, and flor
MIT License
355 stars 29 forks source link

Avoid 2.5 warnings #4

Closed utilum closed 6 years ago

utilum commented 6 years ago
$ ruby -cw lib/fugit/cron.rb
lib/fugit/cron.rb:31: warning: assigned but unused variable - original
lib/fugit/cron.rb:97: warning: shadowing outer local variable - s
lib/fugit/cron.rb:126: warning: shadowing outer local variable - wd
lib/fugit/cron.rb:126: warning: shadowing outer local variable - hsh
lib/fugit/cron.rb:332: warning: shadowing outer local variable - a
lib/fugit/cron.rb:337: warning: shadowing outer local variable - a
lib/fugit/cron.rb:342: warning: shadowing outer local variable - a
lib/fugit/cron.rb:348: warning: shadowing outer local variable - a
lib/fugit/cron.rb:353: warning: shadowing outer local variable - a
lib/fugit/cron.rb:361: warning: shadowing outer local variable - a
Syntax OK

$ ruby -cw lib/fugit/cron.rb
lib/fugit/duration.rb:132: warning: shadowing outer local variable - h
lib/fugit/duration.rb:187: warning: shadowing outer local variable - h
lib/fugit/duration.rb:204: warning: shadowing outer local variable - h
lib/fugit/duration.rb:315: warning: shadowing outer local variable - t
Syntax OK

$ ruby -cw lib/fugit/nat.rb
lib/fugit/nat.rb:52: warning: shadowing outer local variable - a
Syntax OK

Some of these appear in Rails CI

jmettraux commented 6 years ago

Thanks for the heads up! I will integrate that soon!

jmettraux commented 6 years ago

Many thanks.

I followed your suggestion.

I released 1.1.3, I hope the Rails CI will look better.

Thanks again and kind regards.