floraison / fugit

time tools (cron, parsing, durations, ...) for Ruby, rufus-scheduler, and flor
MIT License
355 stars 29 forks source link

Problem parsing 'every 12 hours at minute 50' #41

Closed jeromedalbert closed 3 years ago

jeromedalbert commented 3 years ago

Issue description

Fugit::Nat.parse('every 12 hours at minute 50').to_cron_s returns "50 * * * *" when it should return "50 0,12 * * *". The hours are getting ignored.

How to reproduce

require 'fugit'
Fugit::Nat.parse('every 12 hours at minute 50').to_cron_s

#=> "50 * * * *"

Expected behaviour

require 'fugit'
Fugit::Nat.parse('every 12 hours at minute 50').to_cron_s

#=> "50 0,12 * * *" (or "50 */12 * * *")

Context

Darwin Jeromes-2017-MBP.local 19.6.0 Darwin Kernel Version 19.6.0: Sun Jul  5 00:43:10 PDT 2020; root:xnu-6153.141.1~9/RELEASE_X86_64 x86_64
ruby 2.7.1p83 (2020-03-31 revision a0c7c23c9c) [x86_64-darwin19]
(secs:1596594797.9150012,utc~:"2020-08-05 02:33:17.9150011539459229",ltz~:"PDT")
(etz:nil,tnz:"PDT",tziv:"2.0.2",tzidv:nil,rv:"2.7.1",rp:"x86_64-darwin19",win:false,rorv:nil,astz:nil,eov:"1.2.4",eotnz:#<TZInfo::TimezoneProxy: America/Ensenada>,eotnfz:"-0700",eotlzn:"America/Ensenada",eotnfZ:"PDT",debian:nil,centos:nil,osx:"zoneinfo/America/Los_Angeles")
jmettraux commented 3 years ago

Merci, je crois que c'est réparé maintenant. Si non, dis-le moi ici.

Je viens de libérer une version 1.3.7 contenant ce changement.

Si tu remarques quoi que cela d'autre, n'hésite pas à ouvrir une nouvelle issue.

Encore merci et meilleures salutations.

jeromedalbert commented 3 years ago

You fixed this issue so quickly! Merci beaucoup