search

floraison / fugit

time tools (cron, parsing, durations, ...) for Ruby, rufus-scheduler, and flor
MIT License
353 stars 29 forks source link

Fugit.parse_cronish(str) and .do_parse_cronish(str) #70

Closed jmettraux closed 1 year ago

jmettraux commented 2 years ago

A combo of Fugit.parse_cron and Fugit.parse_nat that returns a Fugit;:Cron instance (or nil).

To cover the case at https://github.com/ondrejbartas/sidekiq-cron/pull/312

markets commented 1 year ago

Hello @jmettraux 👋🏼

I'm one of the maintainers of sidekiq-cron. Just sending a friendly ping 🙏🏼 this provides a much better API for parsing user generated content 👌🏼

jmettraux commented 1 year ago

Hey @markets, thanks for the ping!

Give me one or two days. And thanks for your hard work on sidekiq-cron.

jmettraux commented 1 year ago

Hello @markets,

if you could double-check the code above, please. I'll release 1.8.0 as soon as it's ironed out.

Thanks in advance!

markets commented 1 year ago

hi @jmettraux, just opened a pull request using this new API: https://github.com/sidekiq-cron/sidekiq-cron/pull/385

It seems to work fine!

jmettraux commented 1 year ago

Fugit 1.8.0 has been released.

Thanks again for the ping! Please tell me if you need anything else. Kind regards.