floralvikings / jira-connector

NodeJS Wrapper for the Jira REST API
http://floralvikings.github.io/jira-connector/
MIT License
373 stars 180 forks source link

getFavoriteFilters() -> getFavouriteFilters() #124

Closed njoerd114 closed 5 years ago

njoerd114 commented 5 years ago

Function naming should be consistent...

floralvikings commented 5 years ago

Nice catch!

I'd rather not break the API for a typo; I'll keep this pull request open, however, and merge it next time a major version is released.

MrRefactoring commented 5 years ago

I'm afraid the spelling variant of a favorite is correct.

After studying this topic, I realized that both this option and that is true. Therefore, I see no reason to add this to the code.

Thank you for your participation in the project!