floralvikings / jira-connector

NodeJS Wrapper for the Jira REST API
http://floralvikings.github.io/jira-connector/
MIT License
373 stars 180 forks source link

JWT auth support #226

Closed ItamarM closed 4 years ago

ItamarM commented 4 years ago

fixes #136

MrRefactoring commented 4 years ago

It's awesome! Could you just do the indented PR separately?

ItamarM commented 4 years ago

@MrRefactoring sorry, i guess one of my plugins over-written this. How about now?

MrRefactoring commented 4 years ago

@mochja can you test it?

ItamarM commented 4 years ago

@MrRefactoring if it helps i tested it internally. As long as you:

  1. Supply the right configuration
  2. Ask for at the right scopes (READ, WRITE if you intend to call write methods and so on).
  3. Call the supported API paths (some paths are not supported by connected apps as documented by Atlassian - you will get 403 if you make such attempt).
ItamarM commented 4 years ago

@MrRefactoring - are you waiting for @mochja approval on this one?

MrRefactoring commented 4 years ago

I think we can try to add this feature